Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max version for numpy to allow for shap compatibility #1762

Closed
wants to merge 1 commit into from

Conversation

sudrich
Copy link
Contributor

@sudrich sudrich commented May 11, 2023

Fixes #1761.

Summary

Introduce a max version for numpy to ensure compatibility with the current version of shap (see here for context on the issue).

Other Information

@dennisbader
Copy link
Collaborator

The issue here is that the shap repo doesn't seem to be very active, and that the fix is not coming anytime soon (see here). We can fix the numpy version for now but have to think about an alternative before releasing any new Darts version.

@sudrich
Copy link
Contributor Author

sudrich commented May 12, 2023

The issue here is that the shap repo doesn't seem to be very active, and that the fix is not coming anytime soon (see here). We can fix the numpy version for now but have to think about an alternative before releasing any new Darts version.

Yes. There seems to be a fork that wants to take over development (see here). We should probably migrate once they are ready to publish their first version.

@dennisbader
Copy link
Collaborator

I opened a new PR that addresses other fixes for current unit tests (from new statsmodels version). Let's continue in #1766. Will close this one.

@sudrich
Copy link
Contributor Author

sudrich commented May 15, 2023

I opened a new PR that addresses other fixes for current unit tests (from new statsmodels version). Let's continue in #1766. Will close this one.

Thanks for fixing the issue. I saw it arise last week, but didn't have the time to look deeper into it over the weekend.

@akshika47
Copy link

In the meantime I used Python=3.8 and Numpy=1.19.0 versions to get things running but I don't know what other issues that may arise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incompatibility with latest numpy version
3 participants