Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/lagged data static covs #1803

Merged
merged 6 commits into from May 28, 2023
Merged

Conversation

dennisbader
Copy link
Collaborator

Summary

@dennisbader dennisbader requested a review from hrzn as a code owner May 28, 2023 13:55
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.11 ⚠️

Comparison is base (c03c404) 94.25% compared to head (c64b405) 94.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1803      +/-   ##
==========================================
- Coverage   94.25%   94.14%   -0.11%     
==========================================
  Files         125      125              
  Lines       11619    11594      -25     
==========================================
- Hits        10951    10915      -36     
- Misses        668      679      +11     
Impacted Files Coverage Δ
darts/explainability/explainability_result.py 95.00% <ø> (-0.13%) ⬇️
darts/explainability/shap_explainer.py 89.35% <80.00%> (+0.41%) ⬆️
darts/models/forecasting/regression_model.py 97.80% <100.00%> (-0.02%) ⬇️
darts/utils/data/tabularization.py 99.07% <100.00%> (-0.62%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dennisbader dennisbader merged commit 1663a51 into master May 28, 2023
9 checks passed
@dennisbader dennisbader deleted the refactor/lagged_data_static_covs branch May 28, 2023 18:10
alexcolpitts96 pushed a commit to alexcolpitts96/darts that referenced this pull request May 31, 2023
* move static covariates handling to create_lagged_dta

* added tests for shap explainer with static covariates

* fixed bug in ShapExplainer when using selected components

* update changelog

* fix failing unittests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants