Feat/Dockerfile test environment #1878
Conversation
alexcolpitts96
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
- Coverage 94.00% 93.99% -0.01%
==========================================
Files 126 126
Lines 11905 11891 -14
==========================================
- Hits 11191 11177 -14
Misses 714 714 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
It looks super neat and ran smoothly on my device.
I would just slightly change the wording in the comment at the end, just to make sure the docker commands are executed from the appropriate directory.
Also, out of curiosity, I tried swapping ubuntu:latest with python:slim and it works just as well, reducing the size of the image from 3.75GB to 3.22GB. Any benefits from one over the other?
Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com>
There was a problem hiding this comment.
This is really nice, thanks a lot @alexcolpitts96 🚀 In indeed reduced the image size substantially!
I took the freedom to update the INSTALL.md with instructions how to use the docker image (without gradle) and some other simplifications/fixes.
Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com>
The current Dockerfile is an image that builds a container for jupyter.
I updated the Dockerfile to build a dev environment for darts which can be helpful when debugging/testing.