Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly handle passed axis in TimeSeries.plot #1916

Merged
merged 7 commits into from
Aug 1, 2023

Conversation

dennisbader
Copy link
Collaborator

Fixes #1911.

Summary

  • fixes issue where stochastic TimeSeries were not plotted properly when passing a custom ax to TimeSeries.plot()
  • improve plotting to rely on axis rather than pyplot and fig
  • return axis

@dennisbader dennisbader marked this pull request as ready for review July 24, 2023 19:23
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Patch coverage: 92.60% and project coverage change: -0.12% ⚠️

Comparison is base (3376f27) 93.82% compared to head (adb51ee) 93.71%.
Report is 3 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
- Coverage   93.82%   93.71%   -0.12%     
==========================================
  Files         126      131       +5     
  Lines       12214    12648     +434     
==========================================
+ Hits        11460    11853     +393     
- Misses        754      795      +41     
Files Changed Coverage Δ
darts/utils/__init__.py 100.00% <ø> (ø)
darts/utils/timeseries_generation.py 96.15% <ø> (ø)
darts/utils/utils.py 80.58% <ø> (-11.09%) ⬇️
darts/explainability/__init__.py 75.00% <71.42%> (-25.00%) ⬇️
darts/timeseries.py 92.66% <81.81%> (+0.14%) ⬆️
darts/models/forecasting/forecasting_model.py 95.21% <84.00%> (+0.07%) ⬆️
...orical_forecasts/optimized_historical_forecasts.py 88.46% <88.46%> (ø)
darts/explainability/explainability_result.py 92.13% <90.00%> (-2.87%) ⬇️
darts/explainability/shap_explainer.py 87.69% <91.66%> (-1.66%) ⬇️
darts/explainability/tft_explainer.py 93.15% <93.15%> (ø)
... and 8 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dennisbader dennisbader merged commit 137cf8c into master Aug 1, 2023
7 of 9 checks passed
@dennisbader dennisbader deleted the fix/plot_stochastic_axis branch August 1, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Stochastic TimeSeries Plotting on Multiple Axes
3 participants