Feat/fit predict encodings #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1925 +/- ##
==========================================
- Coverage 93.84% 93.81% -0.03%
==========================================
Files 126 126
Lines 12174 12200 +26
==========================================
+ Hits 11425 11446 +21
- Misses 749 754 +5
☔ View full report in Codecov by Sentry. |
madtoinou
requested changes
Jul 31, 2023
darts/tests/dataprocessing/encoders/test_covariate_index_generators.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/encoders/test_covariate_index_generators.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/encoders/test_covariate_index_generators.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/encoders/test_covariate_index_generators.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/encoders/test_covariate_index_generators.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/encoders/test_covariate_index_generators.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/encoders/test_covariate_index_generators.py
Outdated
Show resolved
Hide resolved
darts/tests/dataprocessing/encoders/test_covariate_index_generators.py
Outdated
Show resolved
Hide resolved
Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com>
dennisbader
added a commit
that referenced
this pull request
Aug 4, 2023
* added encode_train_inference to encoders * added generate_fit_predict_encodings to ForecastingModel * simplify TransferrableFut..Model.generatice_predict_encodings * update changelog * Apply suggestions from code review Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com> * apply suggestions from PR review part 2 --------- Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com>
dennisbader
added a commit
that referenced
this pull request
Aug 4, 2023
* udpate dtw example and add dtw to rendered documentation * make all windows inherit from Window * clean up windows * improve dtw documentation * improved forecasting model module documentation * update models and add model links in covariates user guide * add model links to README * update changelog * fix typo in dtw example notebook * remove outdated lines from tide model from before probabilistic support * apply suggestions from PR review * update readme model table * Feat/fit predict encodings (#1925) * added encode_train_inference to encoders * added generate_fit_predict_encodings to ForecastingModel * simplify TransferrableFut..Model.generatice_predict_encodings * update changelog * Apply suggestions from code review Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com> * apply suggestions from PR review part 2 --------- Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com> * update readme * apply suggestions from code review and improve README.md * Update README.md Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com> --------- Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
encode_train_inference()to encoders. This allows to directly generate the encodings for training and predictiongenerate_fit_predict_encodings()toForecastingModel. Encodings can now be generated from the the model for training and prediction together.