Fix/RegressionEnsemble.extreme_lags when models use only covariates lags #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
- Coverage 93.87% 93.87% -0.01%
==========================================
Files 132 132
Lines 12675 12663 -12
==========================================
- Hits 11899 11887 -12
Misses 776 776
☔ View full report in Codecov by Sentry. |
dennisbader
reviewed
Aug 10, 2023
There was a problem hiding this comment.
Thanks for this @madtoinou. I added the two comments we discussed.
Let me know when I can re-review.
…also when none of the forecasting models use target lags
…/darts into fix/reg_ens_extreme_lags
dennisbader
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1867.
Summary
When forecasting models don't use target lags,
RegressionEnsembleModel.extreme_lagsdirectly returnsEnsembleModel.extreme_lagsinstead of subtractingregression_train_n_pointstomin_target_lags(which isNone).