Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/nlinear normalization for multivariate series #2072

Merged
merged 2 commits into from Nov 18, 2023

Conversation

madtoinou
Copy link
Collaborator

Fixes #2035.

Summary

  • Added slicing of the input tensor x when normalizing (only the target features based on the last value of the target features)

Other Information

  • The problem does not occur when shared_weights=True because covariates are not allowed (and normalization is applied to all the dimensions).

@madtoinou madtoinou added this to In review in darts via automation Nov 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (36a1c09) 93.85% compared to head (4edbaa9) 93.85%.

Files Patch % Lines
darts/models/forecasting/nlinear.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
- Coverage   93.85%   93.85%   -0.01%     
==========================================
  Files         134      134              
  Lines       13123    13109      -14     
==========================================
- Hits        12317    12303      -14     
  Misses        806      806              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this @madtoinou

@dennisbader dennisbader merged commit f196665 into master Nov 18, 2023
9 checks passed
darts automation moved this from In review to Done Nov 18, 2023
@dennisbader dennisbader deleted the fix/nlinear_multivar_normalize branch November 18, 2023 15:03
@felixdivo
Copy link
Contributor

Thanks @madtoinou!

@dennisbader dennisbader moved this from Done to Released in darts Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
darts
Released
Development

Successfully merging this pull request may close these issues.

[BUG] NLinear fails to predict >1 variates
4 participants