Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hist fc predict kwargs #2103

Merged
merged 6 commits into from Dec 1, 2023
Merged

Fix/hist fc predict kwargs #2103

merged 6 commits into from Dec 1, 2023

Conversation

dennisbader
Copy link
Collaborator

Fixes #2097.

Summary

  • fixes a bug where some fit_kwargs and predict_kwargs were ignored in historical forecasts when the model's fit/predict methods had *args and **kwargs in the signature
  • moved predict logic from mixed covariates models to MixedCovariatesTorchForecastingModels -> N/DLinear now use the proper logic
  • fixed some text in docs

@dennisbader dennisbader marked this pull request as ready for review December 1, 2023 09:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7cfdf62) 93.91% compared to head (8c429b6) 93.89%.
Report is 1 commits behind head on master.

Files Patch % Lines
darts/models/forecasting/forecasting_model.py 96.55% 1 Missing ⚠️
...arts/models/forecasting/torch_forecasting_model.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2103      +/-   ##
==========================================
- Coverage   93.91%   93.89%   -0.02%     
==========================================
  Files         135      135              
  Lines       13299    13289      -10     
==========================================
- Hits        12490    12478      -12     
- Misses        809      811       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dennisbader for the fix!

@dennisbader dennisbader merged commit b68f64d into master Dec 1, 2023
9 checks passed
@dennisbader dennisbader deleted the fix/hist_fc_predict_kwargs branch December 1, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] how to set mc_dropout for historical_forecasts
3 participants