Fix/ts prepend #2237
Merged
Fix/ts prepend #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madtoinou
force-pushed
the
fix/ts_prepend
branch
from
26fdbba
to
55e210e
Compare
dennisbader
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2230.
Summary
append/prependon two series, the hierarchy and components names of the series with the "earlier" index are retainedappend/prepend_values, the hierarchy and components of the series are retainedOther Information
Not sure if the hierarchy should be retained or not. Since the components don't change, it should be easy to assign the "old" hierarchy to resulting series but at the same time, adding values should not affect the relationship between the components so keeping by default sounds reasonnable.