fix: datetime_attribute account for 0 or 1-indexing of the attributes #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2242 +/- ##
==========================================
+ Coverage 93.95% 93.97% +0.02%
==========================================
Files 135 135
Lines 13501 13499 -2
==========================================
+ Hits 12685 12686 +1
+ Misses 816 813 -3 ☔ View full report in Codecov by Sentry. |
dennisbader
requested changes
Feb 24, 2024
There was a problem hiding this comment.
Very nice @madtoinou thanks a lot 🚀
Had some minor suggestions. I think we should make the first "step" of each freq start at 0 for cyclic encodings (month=1 should result in sin(0), cos(0), similar to hour=0)
…all the generated encodings
dennisbader
approved these changes
Feb 26, 2024
VascoSch92
reviewed
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2219.
Summary
datetime_attribute_timeseries()was not taking into account the indexing of the attribute (1 for month, day or week for example), resulting in a shift of the "zeroed" columnsOther Information