Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MixedCovTorchModels multi TS predictions with n<ocl #2374

Merged
merged 2 commits into from
May 6, 2024

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented May 6, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Summary

  • fixes a bug when calling predict() with a MixedCovariatesTorchForecastingModel (e.g. TiDE, N/DLinear, ...) n<output_chunk_length and a list of series with length len(series) < n, where the predictions did not return the correct number of series.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (2430903) to head (6a98960).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2374      +/-   ##
==========================================
- Coverage   93.79%   93.77%   -0.02%     
==========================================
  Files         138      138              
  Lines       14288    14271      -17     
==========================================
- Hits        13401    13383      -18     
- Misses        887      888       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dennisbader dennisbader merged commit 26d1e1e into master May 6, 2024
9 checks passed
@dennisbader dennisbader deleted the fix/mixed_tfm_models_multi_ts_predict branch May 6, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants