Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make_dists.sh not working with new build #390

Merged
merged 3 commits into from Jul 15, 2021
Merged

Fix make_dists.sh not working with new build #390

merged 3 commits into from Jul 15, 2021

Conversation

tomasvanpottelbergh
Copy link
Contributor

@tomasvanpottelbergh tomasvanpottelbergh commented Jul 15, 2021 •
edited

The make_dists.sh script broke with build>=0.5.0 because of this PR.

This is fixed by including the requirements folder via MANIFEST.in. Also, a pyproject.toml file has been added for build consistency.

@tomasvanpottelbergh tomasvanpottelbergh changed the title Fix/make dists with new build Fix ./make_dists not working with new build Jul 15, 2021
@tomasvanpottelbergh tomasvanpottelbergh changed the title Fix ./make_dists not working with new build Fix ./make_dists.sh not working with new build Jul 15, 2021
@tomasvanpottelbergh tomasvanpottelbergh changed the title Fix ./make_dists.sh not working with new build Fix make_dists.sh not working with new build Jul 15, 2021
hrzn
hrzn approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Does this change the way to build the package, or can we still simply use make_dists.sh ?

@tomasvanpottelbergh
Copy link
Contributor Author

This hasn't changed, just made sure make_dists.sh works again

@tomasvanpottelbergh tomasvanpottelbergh merged commit e258c27 into develop Jul 15, 2021
@tomasvanpottelbergh tomasvanpottelbergh deleted the fix/make-dists-with-new-build branch July 15, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrzn hrzn hrzn approved these changes

@pennfranc pennfranc Awaiting requested review from pennfranc

@TheMP TheMP Awaiting requested review from TheMP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomasvanpottelbergh @hrzn