Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for untrained models for copying of model parameters #728

Merged
merged 2 commits into from
Jan 9, 2022

Conversation

dennisbader
Copy link
Collaborator

Addresses #724.

Summary

  • instantiating ensemble models with fitted/trained forecasting model resulted in deepcopy error.
  • added check for untrained models with explanatory error message.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022

Codecov Report

Merging #728 (93d2a39) into master (8fa7dbf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files          67       67           
  Lines        6731     6731           
=======================================
  Hits         6113     6113           
  Misses        618      618           
Impacted Files Coverage Δ
darts/models/forecasting/ensemble_model.py 93.87% <100.00%> (+0.12%) ⬆️
darts/utils/likelihood_models.py 96.03% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa7dbf...93d2a39. Read the comment docs.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dennisbader dennisbader merged commit 4a97140 into master Jan 9, 2022
@madtoinou madtoinou deleted the fix/ensemble_model_copying branch July 5, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants