Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed non contiguous error when using lstm_layers > 1 on gpu #740

Merged
merged 1 commit into from Jan 15, 2022

Conversation

dennisbader
Copy link
Collaborator

Fixes #722, #730

  • fixes TFTModel non contiguous error with lstm_layers > 1 on GPU.
  • no performance losses observed

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #740 (f4e0cb4) into master (adde52a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
- Coverage   90.80%   90.80%   -0.01%     
==========================================
  Files          67       67              
  Lines        6741     6740       -1     
==========================================
- Hits         6121     6120       -1     
  Misses        620      620              
Impacted Files Coverage Δ
darts/models/forecasting/tft_model.py 95.66% <100.00%> (ø)
darts/utils/likelihood_models.py 96.04% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adde52a...f4e0cb4. Read the comment docs.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dennisbader dennisbader merged commit ddc84a2 into master Jan 15, 2022
@dennisbader dennisbader deleted the fix/tft_gpu_contiguous branch January 15, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run on CPU not on gpu
3 participants