Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/set up flake8 #749

Merged
merged 8 commits into from Jan 21, 2022
Merged

Feat/set up flake8 #749

merged 8 commits into from Jan 21, 2022

Conversation

tomasvanpottelbergh
Copy link
Contributor

@tomasvanpottelbergh tomasvanpottelbergh commented Jan 21, 2022

Fixes #718.

  • Sets up flake8 to be compatible with Black
  • Enforces flake8 in CI
  • Add flake8 pre-commit hook

TODO:

  • Add .git-blame-ignore-revs file for commit applying black to codebase (see Fix/flake8 issues #748)
  • Add more pre-commit documentation

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #749 (3daf285) into master (96125f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          67       67           
  Lines        6734     6734           
=======================================
  Hits         6114     6114           
  Misses        620      620           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96125f8...3daf285. Read the comment docs.

@tomasvanpottelbergh tomasvanpottelbergh merged commit d94428a into master Jan 21, 2022
@madtoinou madtoinou deleted the feat/set-up-flake8 branch July 5, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linting check to CI/CD
3 participants