Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/simple statistics #773

Merged
merged 12 commits into from
Feb 10, 2022
Merged

Fix/simple statistics #773

merged 12 commits into from
Feb 10, 2022

Conversation

gnwhr
Copy link
Contributor

@gnwhr gnwhr commented Feb 7, 2022

Fixes #719 .

Summary

Replaced "Simple statistics" methods with new functions that accept stochastic TimeSeries.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #773 (a3c6507) into master (ec6ccf8) will decrease coverage by 0.51%.
The diff coverage is 20.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   90.80%   90.29%   -0.52%     
==========================================
  Files          67       68       +1     
  Lines        6752     6777      +25     
==========================================
- Hits         6131     6119      -12     
- Misses        621      658      +37     
Impacted Files Coverage Δ
darts/metrics/metrics.py 100.00% <ø> (ø)
darts/timeseries.py 82.87% <18.86%> (-3.16%) ⬇️
darts/models/forecasting/theta.py 89.14% <100.00%> (ø)
darts/utils/data/inference_dataset.py 94.54% <0.00%> (-1.82%) ⬇️
darts/models/forecasting/regression_model.py 96.61% <0.00%> (-1.14%) ⬇️
darts/models/forecasting/forecasting_model.py 96.55% <0.00%> (-0.82%) ⬇️
darts/utils/timeseries_generation.py 95.49% <0.00%> (ø)
darts/models/forecasting/random_forest.py 100.00% <0.00%> (ø)
darts/models/forecasting/gradient_boosted_model.py 100.00% <0.00%> (ø)
...arts/models/forecasting/linear_regression_model.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6ccf8...a3c6507. Read the comment docs.

@gnwhr gnwhr requested a review from hrzn February 7, 2022 13:54
Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, thanks! I added a few comments.
Could you also add some unit tests? Thanks :)

darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/tests/test_timeseries.py Outdated Show resolved Hide resolved
darts/tests/test_timeseries.py Show resolved Hide resolved
Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@gnwhr gnwhr marked this pull request as ready for review February 10, 2022 12:32
Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gnwhr gnwhr merged commit b51b3af into unit8co:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "Simple statistics" functions of TimeSeries.
3 participants