Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/int index warnings #777

Merged
merged 12 commits into from Feb 15, 2022
Merged

Fix/int index warnings #777

merged 12 commits into from Feb 15, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Feb 9, 2022

Remove Int64Index support and keep only RangeIndex support.

As a consequence, this means that TimeSeries cannot have missing dates anymore (which was possible before with Int64Index; RangeIndex do not have holes by construction).

I had to adapt

Some warnings remain for the time being because of statsmodels.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #777 (33294f9) into master (508d60a) will increase coverage by 0.22%.
The diff coverage is 78.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   90.72%   90.94%   +0.22%     
==========================================
  Files          68       68              
  Lines        6746     6803      +57     
==========================================
+ Hits         6120     6187      +67     
+ Misses        626      616      -10     
Impacted Files Coverage Δ
darts/utils/data/encoders.py 96.69% <ø> (ø)
darts/utils/data/training_dataset.py 89.47% <ø> (ø)
darts/timeseries.py 88.02% <77.77%> (+1.99%) ⬆️
darts/utils/data/encoder_base.py 93.69% <100.00%> (ø)
darts/utils/timeseries_generation.py 95.49% <100.00%> (ø)
darts/metrics/metrics.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508d60a...33294f9. Read the comment docs.

Copy link
Contributor

@brunnedu brunnedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this important update! 🚀
Looks good to me, but it would be good if someone more familiar with xarray could take a look.

darts/timeseries.py Outdated Show resolved Hide resolved
@hrzn hrzn merged commit da84f07 into master Feb 15, 2022
@madtoinou madtoinou deleted the fix/int-index-warnings branch July 5, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants