Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tbats #816

Merged
merged 22 commits into from Mar 9, 2022
Merged

Feat/tbats #816

merged 22 commits into from Mar 9, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Feb 22, 2022

New models: BATS and TBATS

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #816 (44a5fbf) into master (ae47aba) will decrease coverage by 0.08%.
The diff coverage is 85.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
- Coverage   91.32%   91.24%   -0.09%     
==========================================
  Files          69       70       +1     
  Lines        6872     6967      +95     
==========================================
+ Hits         6276     6357      +81     
- Misses        596      610      +14     
Impacted Files Coverage Δ
darts/models/forecasting/tbats.py 85.10% <85.10%> (ø)
darts/models/__init__.py 76.74% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae47aba...44a5fbf. Read the comment docs.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool update, thanks! 👍 Looks good :) just added a couple of minor comments.

darts/models/forecasting/tbats.py Show resolved Hide resolved
requirements/core.txt Outdated Show resolved Hide resolved
darts/models/forecasting/tbats.py Outdated Show resolved Hide resolved
darts/models/forecasting/tbats.py Outdated Show resolved Hide resolved
darts/models/forecasting/tbats.py Outdated Show resolved Hide resolved
darts/models/forecasting/tbats.py Outdated Show resolved Hide resolved
darts/models/forecasting/tbats.py Show resolved Hide resolved
darts/models/forecasting/tbats.py Outdated Show resolved Hide resolved
darts/models/forecasting/tbats.py Outdated Show resolved Hide resolved
darts/models/forecasting/tbats.py Show resolved Hide resolved
@hrzn hrzn merged commit 16bece0 into master Mar 9, 2022
@madtoinou madtoinou deleted the feat/tbats branch July 5, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants