Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/encoders with fit from ds #829

Merged
merged 3 commits into from Mar 1, 2022
Merged

Fix/encoders with fit from ds #829

merged 3 commits into from Mar 1, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Mar 1, 2022

predict() is not working if called after fit_from_dataset(). This fixes it.

dennisbader
dennisbader approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@hrzn hrzn merged commit 4920de0 into master Mar 1, 2022
@madtoinou madtoinou deleted the fix/encoders-with-fit-from-ds branch July 5, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisbader dennisbader dennisbader approved these changes

@tomasvanpottelbergh tomasvanpottelbergh Awaiting requested review from tomasvanpottelbergh

@brunnedu brunnedu Awaiting requested review from brunnedu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hrzn @dennisbader