Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/quantile-multiple-ts-prediction #853

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Fix/quantile-multiple-ts-prediction #853

merged 6 commits into from
Mar 21, 2022

Conversation

gnwhr
Copy link
Contributor

@gnwhr gnwhr commented Mar 17, 2022

Summary

  • Now instances of RegressionModel capable of fitting quantiles correctly work with multi TimeSeries input
  • Registered RegressionModel instances capable of fitting quantiles to more tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #853 (27007e6) into master (a7abedf) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
+ Coverage   91.40%   91.45%   +0.04%     
==========================================
  Files          70       71       +1     
  Lines        7106     7147      +41     
==========================================
+ Hits         6495     6536      +41     
  Misses        611      611              
Impacted Files Coverage Δ
darts/models/forecasting/gradient_boosted_model.py 100.00% <100.00%> (ø)
...arts/models/forecasting/linear_regression_model.py 94.73% <100.00%> (-0.58%) ⬇️
darts/models/forecasting/regression_model.py 97.11% <100.00%> (+0.34%) ⬆️
darts/utils/losses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda8f94...27007e6. Read the comment docs.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

darts/models/forecasting/regression_model.py Outdated Show resolved Hide resolved
darts/models/forecasting/regression_model.py Outdated Show resolved Hide resolved
@gnwhr gnwhr merged commit 490863f into master Mar 21, 2022
@gnwhr gnwhr deleted the fix/quantile-multiple-ts branch March 21, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants