Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fit_called checks in global models #944

Merged
merged 4 commits into from May 18, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented May 4, 2022

Fixes #764

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #944 (f6711f5) into master (611e411) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #944   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files          74       74           
  Lines        7398     7399    +1     
=======================================
+ Hits         6784     6785    +1     
  Misses        614      614           
Impacted Files Coverage Δ
darts/models/forecasting/forecasting_model.py 96.77% <100.00%> (-0.02%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.35% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611e411...f6711f5. Read the comment docs.

@hrzn hrzn merged commit adb66fd into master May 18, 2022
@madtoinou madtoinou deleted the fix/check-fit-called-global-models branch July 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlobalForecastingModel fails to check fit_called
2 participants