New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change order of arguments for metric in gridsearch #989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Could you maybe change the docstring of the gridsearch
and backtest
methods to make this clear?
Something like
metric
A function that takes two TimeSeries instances as inputs (actual and prediction, in this order), and returns a float error value.
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 77 77
Lines 7861 7861
=======================================
Hits 7314 7314
Misses 547 547
Continue to review full report at Codecov.
|
@ClaraGrthns are you still willing to help us close this PR? We can do it as soon as the docstrings are updated. |
Yes, I am sorry! I will do it next Tuesday! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ClaraGrthns
Do you agree to be mentioned / acknowledged in the changelog?
@ClaraGrthns the new docstring line is too long, which causes the linting checks to fail. Could you break the line? Thanks. |
Just added the line break.
yes, sure! |
Fixes #979.
Summary
Metric in gridsearch method of the forecasting class now receives correct order of arguments: First the actual series, second the predicted/fitted series.