Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unitaryhack] Added qiskit backends and tested #1360

Closed
wants to merge 6 commits into from

Conversation

RamAIbot
Copy link

@RamAIbot RamAIbot commented Jun 17, 2022

I have added the code to use qiskit backend simulators in the "execute_with_shots" function. The corresponding test file is in "testing.py"

I have tested using 3 simulators of the qiskit. The circuit I tested with is the bell state circuit.

image

Fixes #1163

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch RamAIbot/mitiq/master

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @RamAIbot, thank you for submitting a PR to Mitiq! We will respond as soon as possible, and if you have any questions in the meantime, you can ask us on the Unitary Fund Discord.

@Misty-W
Copy link
Contributor

Misty-W commented Jun 17, 2022

thanks for the PR, @RamAIbot, you're off to a good start! I see the validation is failing- looks like there are a couple issues with types.

Also, I noticed you commented out some lines, can you remove them? Commented out lines can make the code "cluttered", and we can always get the original back, there are multiple ways to do that in Git.

@Misty-W Misty-W self-requested a review June 17, 2022 21:26
@Misty-W
Copy link
Contributor

Misty-W commented Jun 17, 2022

Fixes #1163

@RamAIbot
Copy link
Author

Hi @Misty-W ,
I edited my code and it works for the test function which I created. But the problem is that it didn't work on the
test_execute_with_shots() function in test_qiskit_utils.py since I am not sure where to get the simulator name and other parameters I defines in my execute_with_shots function.

If possible can we have a discord meeting to discuss on this.

@Misty-W
Copy link
Contributor

Misty-W commented Jun 19, 2022

Sure, I can meet you tomorrow. I’m in the US Pacific time zone

@natestemen
Copy link
Member

superseded by #1371

@natestemen natestemen closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include backend option for real hardware in mitiq.interface.mitiq_qiskit.qiskit_utils.execute_with_shots
4 participants