Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for intermittent failures of test_execute_with_pauli_twirling #1931

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

Misty-W
Copy link
Contributor

@Misty-W Misty-W commented Jul 25, 2023

Description

Temporary fix for intermittent failures of test_execute_with_pauli_twirling: adjust allowed upper bound of expectation value from 0.4 to 0.5.

Longer-term fix (issue #1914) is to test PT in a way that doesn't treat it as a mitigation technique and remove the execute_with_pauli_twirling function while retaining mitigate_executor for composing Pauli Twirling with error mitigation techniques in the Mitiq workflow.

Fixes #1858.


License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@Misty-W Misty-W linked an issue Jul 25, 2023 that may be closed by this pull request
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch unitaryfund/mitiq/1858-test-of-execute_w_pt-fails-intermittently

@Misty-W Misty-W requested a review from natestemen July 25, 2023 23:08
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1931 (73c82a0) into master (6761302) will increase coverage by 98.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1931       +/-   ##
===========================================
+ Coverage        0   98.47%   +98.47%     
===========================================
  Files           0       79       +79     
  Lines           0     3681     +3681     
===========================================
+ Hits            0     3625     +3625     
- Misses          0       56       +56     

see 79 files with indirect coverage changes

Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@natestemen natestemen merged commit 0180c40 into master Jul 26, 2023
23 checks passed
@natestemen natestemen deleted the 1858-test-of-execute_w_pt-fails-intermittently branch July 26, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test of execute_w_pt fails intermittently
2 participants