remove redundant imports from top level __init__.py
#2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Misty Wahl <misty@unitary.fund>
natestemen
force-pushed
the
mw-nts-remove-redundant-imports
branch
from
9f8490c
to
654f132
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2206 +/- ##
==========================================
- Coverage 98.31% 98.28% -0.03%
==========================================
Files 90 90
Lines 4262 4259 -3
==========================================
- Hits 4190 4186 -4
- Misses 72 73 +1 ☔ View full report in Codecov by Sentry. |
FarLab
approved these changes
Feb 27, 2024
|
Thanks Farrokh! I've added a comment over on the issue to explain what happened here #2202 (comment). Thanks for making sure we have it documented, and thanks for the review! First PR of milestone 0.35 💪🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #2202 by removing the lines all together as they are redundant to the
__init__.pyfiles that live in each of those respective directories.