Use python 3.11 on RTD #2231
Merged
Use python 3.11 on RTD #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natestemen
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2231 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 90 90
Lines 4257 4257
=======================================
Hits 4184 4184
Misses 73 73 ☔ View full report in Codecov by Sentry. |
cosenal
approved these changes
Mar 18, 2024
|
Just to add another data point from a local build on my machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Read The Docs is using python 3.10 to build our documentation. This was originally part of our upgrade to support python 3.11 (#1663), but we went forward without it because there was some troubles with python 3.11 on RTD.
This is only one data point, but
lateston RTD is building in 2697 seconds, and this PR is building in 2351 seconds. 5 minute improvement! Thanks python 3.11! Now if we can get our RTD build below 30 min that would be really cool, but something to think about down the line.fixes #1790