-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate import #2312
Remove duplicate import #2312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2312 +/- ##
==========================================
- Coverage 98.32% 98.23% -0.10%
==========================================
Files 91 87 -4
Lines 4308 4068 -240
==========================================
- Hits 4236 3996 -240
Misses 72 72 ☔ View full report in Codecov by Sentry. |
The codecov/project failure looks like a hiccup on codecov side. Upon inspection of the coverage report there are no files affected. |
Hm, do you know why codecov is complaining that this line was an "indirect change?" https://app.codecov.io/gh/unitaryfund/mitiq/pull/2312/indirect-changes |
It's unrelated to this PR. What is happening is that the order in which the tests get executed affects that line. Since the order test is random, that line ends up being covered or not. In fact, if you look at the list of recent coverage reports, you can see the score oscillates between 98.29% and 98.33%. |
@jordandsullivan Please take another look. This time the codecov makes sense, as I removed those 4 test files from the coverage. |
Description
tests
otherwise the tests themselves are picked up by codecov, because of this:mitiq/.coveragerc
Line 3 in 8c24a9b