Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate import #2312

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Remove duplicate import #2312

merged 2 commits into from
Apr 23, 2024

Conversation

cosenal
Copy link
Contributor

@cosenal cosenal commented Apr 21, 2024

Description

  1. Removes a duplicate import (and sort them while we are at it)
  2. Rename a test folder to tests otherwise the tests themselves are picked up by codecov, because of this:
    */tests/*

@cosenal cosenal changed the title Remove duplicate imports Remove duplicate import Apr 21, 2024
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (5365e7a) to head (98f2080).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2312      +/-   ##
==========================================
- Coverage   98.32%   98.23%   -0.10%     
==========================================
  Files          91       87       -4     
  Lines        4308     4068     -240     
==========================================
- Hits         4236     3996     -240     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosenal
Copy link
Contributor Author

cosenal commented Apr 22, 2024

The codecov/project failure looks like a hiccup on codecov side. Upon inspection of the coverage report there are no files affected.

@jordandsullivan
Copy link
Contributor

Hm, do you know why codecov is complaining that this line was an "indirect change?" https://app.codecov.io/gh/unitaryfund/mitiq/pull/2312/indirect-changes

@cosenal
Copy link
Contributor Author

cosenal commented Apr 22, 2024

Hm, do you know why codecov is complaining that this line was an "indirect change?" https://app.codecov.io/gh/unitaryfund/mitiq/pull/2312/indirect-changes

It's unrelated to this PR. What is happening is that the order in which the tests get executed affects that line. Since the order test is random, that line ends up being covered or not. In fact, if you look at the list of recent coverage reports, you can see the score oscillates between 98.29% and 98.33%.
I will try to find the root cause of this "non-determinism"

@cosenal
Copy link
Contributor Author

cosenal commented Apr 22, 2024

@jordandsullivan Please take another look. This time the codecov makes sense, as I removed those 4 test files from the coverage.

@cosenal cosenal merged commit fe3a666 into main Apr 23, 2024
17 of 18 checks passed
@cosenal cosenal deleted the fix-duplicated-imports branch April 23, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants