Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate readme entery in toctree #2362

Merged
merged 1 commit into from
May 11, 2024

Conversation

jordandsullivan
Copy link
Contributor

@jordandsullivan jordandsullivan commented May 10, 2024

Description

This fixes the issue in my local build. This also fixes the "2nd readme" issue in #2331 (comment)

Screen Shot 2024-05-10 at 4 02 03 PM

The "next" button goes to the user guide rather than a duplicate of the Readme:
Screen Shot 2024-05-10 at 4 03 17 PM

-->

Screen Shot 2024-05-10 at 3 59 26 PM

License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@jordandsullivan jordandsullivan linked an issue May 10, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (6ff6c08) to head (2ee9d09).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2362   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          87       87           
  Lines        4059     4059           
=======================================
  Hits         3987     3987           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@purva-thakre purva-thakre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jordan!

@jordandsullivan jordandsullivan merged commit 2a41ad0 into main May 11, 2024
18 checks passed
@jordandsullivan jordandsullivan deleted the 2330-readme-is-repeated-twice-in-the-docs branch May 11, 2024 15:11
@cosenal cosenal added this to the v0.37.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme is repeated twice in the docs
3 participants