Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete old version of diagram, as unnecessary #2364

Merged
merged 1 commit into from
May 14, 2024

Conversation

jordandsullivan
Copy link
Contributor

@jordandsullivan jordandsullivan commented May 13, 2024

Description

In original branch to fix the name of the qse module in the diagram, the old version of the image was left in unnecessarily. Removing here.


License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@jordandsullivan jordandsullivan linked an issue May 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (2a41ad0) to head (732e12f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2364   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          87       87           
  Lines        4059     4059           
=======================================
  Hits         3987     3987           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the diagram-v2 back to "diagram" in addition to deleting the old file?

I was reminded of this comic :)

@jordandsullivan
Copy link
Contributor Author

Should we rename the diagram-v2 back to "diagram" in addition to deleting the old file?

I was reminded of this comic :)

Lol I don't have a strong preference on this. But tbf it's not like we're calling it "final version," just incrementing the version number so it's clear a previous version existed in case people still have it referenced somewhere.

@jordandsullivan jordandsullivan merged commit 7a7bbfd into main May 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module name incorrect in QSE diagram
2 participants