unitb-config revamp #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config file's name changed from z3_config.conf to z3_config.yml. TODO: there's a slight issue with the yaml library treating all of Z3Config's fields as String, in that it will require the numbers to be explicitly quoted to be considered as string literals; and otherwise it will ignore them. We'll try to fix this by generalizing the Document type class and the functions using it.
- literate-unitb-config compiles again - Add traverseOf (similar to lensOf and prismOf) - Swap `fieldWith`'s arguments to make them consistent with `field`
yaml < 0.8.22 causes literate-unitb-logic's test suite to throw an exception: Control.Concurrent.STM.atomically was nested Possibly related: snoyberg/yaml#86 Not sure about the exact cause, but we don't seem to have the issue with yaml >= 0.8.22, so I'm bumping the lower bound as a workaround.
cipher1024
requested changes
Aug 23, 2017
| -> BiParser Maybe b doc String | ||
| field :: (Document doc,ToJSON a,FromJSON a) | ||
| => String -> (b -> a) | ||
| -> BiParser Maybe b doc a | ||
| field k f = BiParser (makeNode k . f) (lookupDoc k) | ||
|
|
There was a problem hiding this comment.
Can you please align => and -> with ::?
| -> Traversal' s a | ||
| traverseOf def (BiParser f g) h x = | ||
| (\i -> f i def) <$> h (runIdentity $ g x) | ||
| -- f <$> h (runIdentity $ g x) <*> pure def |
There was a problem hiding this comment.
Can you remove this commented line please?
| @@ -74,4 +74,4 @@ main = execParser opts >>= apply | |||
| where | |||
| opts = info ( helper <*> commandLineOpts ) | |||
| $ fullDesc | |||
| <> header "unitb-setting - customize the preferences for verifier" | |||
| <> header "unitb-config - customize the preferences for verifier" | |||
There was a problem hiding this comment.
The error message was broken. Good thing you had to change it
| @@ -21,6 +23,7 @@ instance (Applicative f) => Applicative (BiParser f a b) where | |||
|
|
|||
| -- instance Profunctor (BiParser a) where | |||
There was a problem hiding this comment.
Let's remove this commented code. If we need a Profunctor instance, we'll just add it from scratch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of changes to the
literate-unitb-configexecutable,unitb-config:ConfigFilein favour ofyamlfor the configuration file. The configuration file was renamed fromz3_config.conftoz3_config.ymlto reflect the change.Documenttype class to reduce duplication (with respect tofield,fieldWith, and their primed variants) and to accommodate for introduction ofyaml.unitb-optiontounitb-configconsistently.