Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names of derived units #367

Closed
puigru opened this issue Feb 27, 2022 · 2 comments
Closed

Names of derived units #367

puigru opened this issue Feb 27, 2022 · 2 comments

Comments

@puigru
Copy link

puigru commented Feb 27, 2022

This is a revisit of #271.
Many units are without their names because they're derived from others. This greatly reduces the usefulness of Unit#getName.

These all return null:
Units.GRAM.getName() (expected: Gram)
Units.METRE.prefix(MetricPrefix.KILO).getName() (expected: Kilometre)
Units.CUBIC_METRE.getName() (expected: Cubic metre)
... and so on and so forth.

@keilw
Copy link
Member

keilw commented Jul 20, 2022

Except for Units.METRE.prefix(MetricPrefix.KILO).getName() (there's an operation involved and it therefore won't even either name or symbol) the other two can get a name inside the Units collection.

@keilw keilw added this to the 2.1.4 milestone Jul 20, 2022
@keilw keilw modified the milestones: 2.1.4, 2.2 Dec 7, 2022
keilw added a commit that referenced this issue Jun 6, 2023
@keilw
Copy link
Member

keilw commented Jun 6, 2023

Now all units defined inside Units got a name.

@keilw keilw closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants