#67 [FEATURE] Set event name suggestion on Variable Changed event creation #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding 53686d8, you don't need to worry about supporting Unity 2019, feel free to use the 2020+ features. v5 won't need to support 2019. |
|
I would like to suggest to target this PR to the V4.4.x release as I've just sent a PR for this feature targeted at V5. V5 required some additional changes to the AtomDrawer file overall. |
Some time ago it was decided that 4.x won't receive new features but only bug fixes, hence those features target V5 |
AdamRamberg
requested changes
Oct 24, 2022
* Simplified CleanPropertyName - first if-block was catched by second block * Replaced FilterLastIndexOf with typeof(T).Name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtu.be/_seSt3tMZdU
Currently the implementation suggests a name for a new Event or variable when created with the 'Create' button. If the parent of the property is a BaseAtom (Variable, valuelist, FSM etc) the naming structure is: "name of variable/valuelist/FSM" + name of property ("Changed" when you add a variable changed event) + type of Event/variable ("BoolEvent" for example). When you try to create a second default named event the system will add a number at the end just like it is with duplicating GameObjects. Everything can be seen in the video above.
There are some occasions where this default naming scheme can be a bit weird, as you can see with SetIntVariableValue as an example. However if you create custom names for a variable things get quite clear. If there are suggestions for a better naming scheme I will be happy too change things where needed.