Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アウトラインにちらつきが発生する #82

Closed
lilxyzw opened this issue Jul 27, 2021 · 4 comments
Closed

アウトラインにちらつきが発生する #82

lilxyzw opened this issue Jul 27, 2021 · 4 comments

Comments

@lilxyzw
Copy link

lilxyzw commented Jul 27, 2021

現象

SceneにLightProbeが存在するとき、カメラの位置や角度によってアウトラインにちらつきが発生するように見えます。
Outline Pass内のタグに"LightMode"="ForwardBase"を追記することで現象が改善されることを確認していますが、こちらでは十分にデバッグを行えていないためそちらでもご確認いただければ幸いです。

再現方法

  • Unityバージョン: 2018.4.20f1
  • パイプライン: Built-In RP
  1. SceneにModeがBakedのDIrectional Lightを設置、現象が確認しやすいようにリアルタイムライトは無い状態にする
  2. Plane等で簡易的な地形を作成しLightmap Staticにする
  3. 地形に合わせLightProbeを配置、LightProbeの陰影が強いと確認しやすい
  4. ライトをベイクし、Scene内にUTS2でアウトラインを出したマテリアルを適用したメッシュを配置
@Nobuyuki-Kobayashi
Copy link
Contributor

ご報告ありがとうございます。
本件、別の方からも同様の報告を受けておりますので、調査させていただきます。
少々お時間をいただければと存じます。

Nobuyuki-Kobayashi added a commit that referenced this issue Sep 8, 2021
…bug that caused the brightness of the outline to change unexpectedly in some VRChat worlds.
@Nobuyuki-Kobayashi
Copy link
Contributor

修正バージョンのシェーダーのみのUnitypackageです。
よろしかったらテストをしてみてくださいませ。
https://github.com/unity3d-jp/UnityChanToonShaderVer2_Project/blob/dev/legacy/2.0.8/UTS2_ShaderOnly_v2.0.8_Release.unitypackage

Nobuyuki-Kobayashi added a commit that referenced this issue Sep 9, 2021
…bug that caused the brightness of the outline to change unexpectedly in some VRChat worlds.

(The codes of UTS v.2.1.1 for Legacy pipeline are almost equivalent for ones of UTS v.2.0.8., except of the feature supported RTHS.)
@lilxyzw
Copy link
Author

lilxyzw commented Sep 9, 2021

修正ありがとうございます。
v2.0.8に更新することでUnity上でもVRChat上でもアウトラインのちらつきが発生しなくなりました。

@lilxyzw lilxyzw closed this as completed Sep 9, 2021
Nobuyuki-Kobayashi added a commit that referenced this issue Sep 13, 2021
…bug that caused the brightness of the outline to change unexpectedly in some VRChat worlds. (#91)
Nobuyuki-Kobayashi added a commit that referenced this issue Sep 13, 2021
… outline to change unexpectedly in some VRChat worlds. (#92)

* Created new repository for integrated package based on regacy 2.1

* Updated package.json and upm-ci-uts2.yml.

* Renamed some files using UnityChanToonShader to UniversalToonShader in accordance with the package name.

* renamed UTS2_Project~/Package/com.unity.unitychantoonshader2 to com.unity.universaltoonshader

* Updated CHANGELOG.md, LICENSE.md and package.json under UTS2_PROJECT~ folder.

* finxed:manifest.json in UTS2_Project~/Packages

* deleted unnecessary utility source codes.

* Fixed: namespace of UTS2GUI.cs not to use UTJ.*

* Update promotion-uts2.yml

* Added Legacy samples under assets folder, not samples folder yet.

* Fixed an error in UnityGuidRegenerator.cs

* Reassigned new GUID to all the legacy samples.

* Added Universal RP samples GUIDs are not fixed yet.

* Reassigned all the meta GUIDs.

* Legacy samples only, but, without error when imporiting the samples.

* Added URP into the project.

* Added samples for Universal RP.

* Compatible with Unity 2019.3.12f1. Installed HDRP 7.4.3

* Added HDRP samples.

* Scope of shortButtonStyle and meddleButtonStyle are changed.

* Implementing Game light recommendation window.

* Applied feedback from Nobu.

* Implemented GameRecommendationWindow for URP.

* So did the same to Legacy.

* Translated all Japanese comments in Legacy shaders into English.

* Grafted comments  translation from Legacy to Universal.

* Grafted all the comments Nobu has tranlated into English to HDRP.

* Fixed:Camera prefabs' error.

* Default RP is legacy.

* updated .gitignore

* fixed: missing script in legacy box projection scene

* Added dependency to Post Processing stack v2 and removed all v1 files inside the legacy samples.

* Checked  BoxProjection scene to use PPS V2

* Added PostEffectMask, but not enabled.

* Removed post effect after confirming it is not enabled in Kobayashi-san original.

* Added PPS v2 effect to legacy EmissiveAnimation scene.

* Updated some legacy scenes to use PPSv2

* Made SceneLIghts Hi-Cult_filter Test compatible with ppsV2.

* Modifed ToonShader* scenes to use PPSv2.

* Adjusted some parameters in ToonShader_Firely

* Fixed: the point light issue with Vulkan.

* Replaced Japanese comments to English in Lagacy UTS Samples.

* Added Initialization of output data in InitalizeStandardLitSurfaceDataUTS() Thanks to Koji and yuki4080.

* Finished all PPS v2 settings in Legacy sample scenes.

* 2019.3 だとUIないのでテキストエディタで GraphicsSettingsを修正。LightsUseLinearIntensity、LightUseColorTemperature を disable
PointLightTest.unity  Bloom のIntensity を上の状態でも元のレガシーに近くなるように修正
SceneLights Hi_cut Filter_Test.unity PointLightの値を1/10に。元のシーンにBloomはなかったようなのでOFF
ToonShader_Firefly.unity PointLightの値を1/10に。Bloomちょっと調整

* Fixed settings of PPSv2 in 3 test-scenes with Point Lights, expecially Color Grading.
Turned back the intensity value of Directional Light in ToonShader_Firely to the original one.

* Inprogress version for Anime template. Updated the version to  0.0.3-preview.

* Bumped Unity 2019.4.30f1

* Release v.2.1.1 for Legacy pipeline / Bug fix for Issue #82: Fixed a bug that caused the brightness of the outline to change unexpectedly in some VRChat worlds.
(The codes of UTS v.2.1.1 for Legacy pipeline are almost equivalent for ones of UTS v.2.0.8., except of the feature supported RTHS.)

Co-authored-by: Toshiyuki Mori <toshiyuki@unity3d.com>
Co-authored-by: toshiyuki mori <toshiyuki.mori.develop@gmail.com>
@Nobuyuki-Kobayashi
Copy link
Contributor

lilxyzwさん
ご確認ありがとうございます。
今後もよろしくお願いします!
Thank you for your collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants