-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Issue #8 #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge.
@s-bauer |
@ENikS Sorry, but I don't quite understand what you mean |
@ENikS Ok, so I'm still using the same exception, just a different way of serializing and deserializing the exception. The other solution would be to either remove the |
Thank you for your help. Perhaps you could take look at other issues? |
@ENikS Sure, now I'm already familiar with the project. You can expect several PRs in the future! |
The
Unity.RegistrationByConvention
assembly is marked asSecurityTransparent
, meaning I cannot add the SecurityCriticalAttribute at theGetObjectData
method (or at least it has no effect).For .NET Framework there is a
ISafeSerializationData
Interface with which the Serialization can be handled without needing to deal with SecurityPermissions. This is however not supported in .NET Core so I just excluded it using compiler flag.I also added a Limited PermissionSet test which is going to run the Serialization/Deserialization process with a very limited permission set.
In addition I fixed the test, so they are executed for all .NET versions. Thanks to @GreenKn1ght and his commit GreenKn1ght@538f3e6
Let me know if you have any concerns or questions!