Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds multiple character selection #6313

Merged
merged 42 commits into from
Apr 13, 2021

Conversation

MaxIsJoe
Copy link
Contributor

@MaxIsJoe MaxIsJoe commented Mar 30, 2021

Purpose

Ticks one box from #6276
Adds multiple characters support and the ability to select between them.

Notes:

After a bit of struggling with unity's cameras and loading images, It's done! Players now can create an unlimited amount of characters to choose from to roleplay as!

How does this work? All characters are currently stored in a JSON file with all their data and customizations, when the character page opens it loads that JSON file and adds all characters to a list that the player can browse in a new (functional but not all that pretty) UI. Just land on the character you want to use then that's your character that you'll be using for this round.
Don't have a character? Want to edit your current character? no worries, you can do that from the two buttons at the bottom of the the character selector page.

This PR doesn't just come with a character selector, I've also added in two scripts at the request of Bod to capture pictures of the game/UI. This can be used later when we work on fixing the security console and add in some functionality to cameras so we can say cheese.

PS : I've been told that the UI/UX peeps will handle the looks of this later so I've prioritized functionality over shininess.

Changelog:

CL: Multiple character sheets are now supported.
CL: Humans will no longer have wrong skin tones when switching between species.

@github-actions github-actions bot added the UI label Mar 30, 2021
@PerfectTangent
Copy link
Contributor

when you want to make sure maintainers can't merge a PR that isn't quite finished, you can instead open it as a draft PR.

@MaxIsJoe
Copy link
Contributor Author

when you want to make sure maintainers can't merge a PR that isn't quite finished, you can instead open it as a draft PR.

Will keep in mind that for next time

@PerfectTangent
Copy link
Contributor

for your transgressions, I will now speedmerge this PR /s

@MaxIsJoe
Copy link
Contributor Author

for your transgressions, I will now speedmerge this PR /s

image

@MrAsbestos
Copy link
Contributor

Hey btw you can actually convert it into draft

Look around here
image

@MaxIsJoe MaxIsJoe marked this pull request as draft March 30, 2021 01:36
@MaxIsJoe
Copy link
Contributor Author

For some reason the camera refuses to render anything which as a result ends up outputting empty pictures.
anyone knows why this is happening?

@github-actions github-actions bot added the Status: Merge Conflicts No one likes conflicts, solve them! label Mar 30, 2021
@PerfectTangent PerfectTangent added System: Health Tasks related to medical role System: Animation Tasks related to animation system / sprites labels Mar 31, 2021
@corp-0 corp-0 removed the Status: Merge Conflicts No one likes conflicts, solve them! label Apr 2, 2021
@MaxIsJoe MaxIsJoe marked this pull request as ready for review April 2, 2021 21:27
@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Apr 2, 2021

Why is this tagged with "Animation" ?

@PerfectTangent
Copy link
Contributor

because working with cameras and capturing static sprite compositions is animation as far as unity is concerned. Read the description of the label to see the general scope that it covers.

@MaxIsJoe MaxIsJoe mentioned this pull request Apr 2, 2021
62 tasks
@PerfectTangent PerfectTangent added the Status: Awaiting Review for PRs that are awaiting reviews/rereviews label Apr 4, 2021
Copy link
Contributor Author

@MaxIsJoe MaxIsJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review time

@PerfectTangent
Copy link
Contributor

@Bod9001 can you help us diagnose some of the bugs we've been experiencing with the character customizer and saving characters?

@Bod9001
Copy link
Member

Bod9001 commented Apr 4, 2021

oh? what would you like me to work on

@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Apr 4, 2021

oh? what would you like me to work on

Characters are being saved incorrectly, where for some reason the game will save two indexes instead of one for no reason even though I have explicitly told it multiple times to save the current character I'm creating/editing instead of the older ones.

@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Apr 5, 2021

Requesting a new review and testing for all the new fixes. Bod's help may no longer be needed.

Edit, not sure what's with codacy and async. Anyone can explain why it wants me to make that change?

@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Apr 5, 2021

Anything else needs to be checked?

@PerfectTangent
Copy link
Contributor

I'd like to give it another go in the editor when I wake up

@github-actions github-actions bot added the Status: Merge Conflicts No one likes conflicts, solve them! label Apr 6, 2021
@Bod9001
Copy link
Member

Bod9001 commented Apr 7, 2021

oh yeah does this have the box for serialising and de-serialising text you input for the character selected?

@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Apr 7, 2021

oh yeah does this have the box for serialising and de-serialising text you input for the character selected?

Yep, just edit or create a new character and give it a character or get your character's json thingy.

@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Apr 8, 2021

I've fixed some more issues for the character creator, ready for one more review.
There should be no longer any issues related to characters spawning with wrong sheets, editing the wrong character sheets, buttons not being clickable and layering issues when capturing previews.

@MaxIsJoe
Copy link
Contributor Author

MaxIsJoe commented Apr 9, 2021

Everything seems to be fine from testing, no more issues related to this PR.

We can merge now.

@Bod9001 Bod9001 removed Status: Merge Conflicts No one likes conflicts, solve them! Status: DNM "Do Not Merge". Don't merge this Pull Request, as changes where requor further additions are needed. labels Apr 10, 2021
@MaxIsJoe
Copy link
Contributor Author

Whoops, I forgot to push this change 2 days ago.
Codacy can now shut the fuck up about this task/void error.

Reminder again, we're done with this PR. We're ready to merge.

@MaxIsJoe
Copy link
Contributor Author

ok for real this time, no more issues.

@Bod9001 Bod9001 merged commit 1f95a32 into unitystation:develop Apr 13, 2021
@MaxIsJoe MaxIsJoe deleted the selectyourchampion branch April 16, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Review for PRs that are awaiting reviews/rereviews System: Animation Tasks related to animation system / sprites System: Health Tasks related to medical role UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants