-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds multiple character selection #6313
Conversation
when you want to make sure maintainers can't merge a PR that isn't quite finished, you can instead open it as a draft PR. |
Will keep in mind that for next time |
for your transgressions, I will now speedmerge this PR /s |
For some reason the camera refuses to render anything which as a result ends up outputting empty pictures. |
a937937
to
39b422e
Compare
Why is this tagged with "Animation" ? |
because working with cameras and capturing static sprite compositions is animation as far as unity is concerned. Read the description of the label to see the general scope that it covers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review time
@Bod9001 can you help us diagnose some of the bugs we've been experiencing with the character customizer and saving characters? |
oh? what would you like me to work on |
Characters are being saved incorrectly, where for some reason the game will save two indexes instead of one for no reason even though I have explicitly told it multiple times to save the current character I'm creating/editing instead of the older ones. |
Requesting a new review and testing for all the new fixes. Bod's help may no longer be needed. Edit, not sure what's with codacy and async. Anyone can explain why it wants me to make that change? |
Anything else needs to be checked? |
I'd like to give it another go in the editor when I wake up |
oh yeah does this have the box for serialising and de-serialising text you input for the character selected? |
Yep, just edit or create a new character and give it a character or get your character's json thingy. |
…y your new characters
… left scroll button
…stealthy when switching characters
d50299e
to
d680bf5
Compare
I've fixed some more issues for the character creator, ready for one more review. |
Everything seems to be fine from testing, no more issues related to this PR. We can merge now. |
Whoops, I forgot to push this change 2 days ago. Reminder again, we're done with this PR. We're ready to merge. |
ok for real this time, no more issues. |
Purpose
Ticks one box from #6276
Adds multiple characters support and the ability to select between them.
Notes:
After a bit of struggling with unity's cameras and loading images, It's done! Players now can create an unlimited amount of characters to choose from to roleplay as!
How does this work? All characters are currently stored in a JSON file with all their data and customizations, when the character page opens it loads that JSON file and adds all characters to a list that the player can browse in a new (functional but not all that pretty) UI. Just land on the character you want to use then that's your character that you'll be using for this round.
Don't have a character? Want to edit your current character? no worries, you can do that from the two buttons at the bottom of the the character selector page.
This PR doesn't just come with a character selector, I've also added in two scripts at the request of Bod to capture pictures of the game/UI. This can be used later when we work on fixing the security console and add in some functionality to cameras so we can say cheese.
PS : I've been told that the UI/UX peeps will handle the looks of this later so I've prioritized functionality over shininess.
Changelog:
CL: Multiple character sheets are now supported.
CL: Humans will no longer have wrong skin tones when switching between species.