New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Multi pass parsing over multi source files #1495
Open
masatake
wants to merge
11
commits into
universal-ctags:master
Choose a base branch
from
masatake:multi-pass-parsing-over-multi-source-files
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8c5acfd
main: change the type of passCount parameter of createTagsForFile fro…
masatake a740929
main: fix a typo in comment
masatake bd361cf
main: introduce mm, infrastructure for multi pass parsing over multi …
masatake 102a5d1
main: implement barrel API for MM
masatake 77642fc
[TEMPORARY] SystemVerilog: convert to multi-pass over multi-source pa…
masatake ee912f3
[TEMPORARY] SystemVerilog: add member(v) kind
masatake 89e13b7
main: introduce addKeywordStrdup
masatake 0069603
[TEMPORARY] SystemVerilog: use addKeywordStrdup to avoid memory leak
masatake d997cb4
fixup! [TEMPORARY] SystemVerilog: add member(v) kind
masatake 6ea7823
docs(web): write about mm/barrel API
masatake bded49b
fixup! main: introduce addKeywordStrdup
masatake File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,13 @@ | |
/* | ||
* FUNCTION PROTOTYPES | ||
*/ | ||
|
||
/* `string' should be allocated statically. */ | ||
extern void addKeyword (const char *const string, langType language, int value); | ||
|
||
/* addKeywordStrdup does strdup `string'. | ||
Duplicated string is freed in freeKeywordTable() */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Extra space in comment There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you. I will make a fixup! commit. |
||
extern void addKeywordStrdup (const char *const string, langType language, int value); | ||
extern int lookupKeyword (const char *const string, langType language); | ||
extern int lookupCaseKeyword (const char *const string, langType language); | ||
extern void freeKeywordTable (void); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand the meaning of "MM". First "M" is for multi, but what is the second for?
Typically you would do something like: "Multi source Files (MF)". That is, capitalize the words used in the abbreviation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MM means "M"ulti pass parsing over "M"ulti source files.
Do I make sense?