New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split c.c into two parts #3332
split c.c into two parts #3332
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3332 +/- ##
==========================================
- Coverage 85.44% 83.16% -2.28%
==========================================
Files 216 218 +2
Lines 50319 52235 +1916
==========================================
+ Hits 42995 43442 +447
- Misses 7324 8793 +1469
Continue to review full report at Codecov.
|
I'm negative about removing the Vera parser. How about doing the following?
The commits up to f2b6293 look good to me. |
@masatake Done. |
Thank you for taking your time. |
It will serve as a compiler of languages other than C/C++ from c.c.
Remove Lang_c, Lang_cpp and additional c/c++ defines, C/C++ entries from the keyword map (which requires updating indexes when calling buildKeywordHash()) and isKnrParamList (which is K&R style C function declaration flag). Fix the resulting compilation errors and make sure units test pass after this.
This is the only keyword with 0's for all languages in KeywordTable.
…ation Remove "task" keyword, all Vera declarations and fix compilation errors.
Done. |
Thank you. Please, wait for awhile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for updating vera.c.
Thank you very much. |
This is what I proposed in
#3327
with some modifications:
c.c
which I left more or less as it was before - I could remove the extra languages if desired, I'm just not sure if it's worth the work since this file probably won't be actively maintained.c-based.c
(and use the parser fromc.c
). The language seems to be mostly dead without any proper documentation and this makesc-based.c
hard to maintain because nobody knows properly what code is there because of Vera and what it should do.c.c
seems to be a good graveyard for Vera to me.I really just fixed the compilation errors and didn't go through the parser in detail - I'm pretty sure that there's some code left which is only specific to C/C++ (but which isn't explicitly guarded for these languages) so there probably are some things which are unnecessary.