Cxx: scan the cork queue instead of the symtab to fill nth fields #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3642 +/- ##
==========================================
- Coverage 82.83% 82.81% -0.02%
==========================================
Files 223 223
Lines 54518 54525 +7
==========================================
- Hits 45159 45155 -4
- Misses 9359 9370 +11
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
cxx--optimize-nth-handling
branch
from
570d949
to
2199908
Compare
Close universal-ctags#3634. If an enum has so many enumerators, the original code, counting enumerators for filling nth fields, takes a too long time. The new code looks up the last enumerator and calculates a new nth value by incrementing the last nth value. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
cxx--optimize-nth-handling
branch
from
2199908
to
0a96308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3634.
If an enum has so many enumerators, the original code, counting enumerators
for filling nth fields, takes a too long time.
The new code looks up the last enumerator and calculates a new nth value
by incrementing the last nth value.