Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: extract views in "create view if not exists VIEW ..." #3850

Merged

Conversation

masatake
Copy link
Member

At least, SQLite supprots the syntax: https://www.sqlite.org/lang_createview.html

At least, SQLite supprots the syntax: https://www.sqlite.org/lang_createview.html

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f727e74) 85.02% compared to head (5a65c08) 85.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3850   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files         228      228           
  Lines       53900    53901    +1     
=======================================
+ Hits        45831    45832    +1     
  Misses       8069     8069           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@b4n b4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know SQL nearly enough, but LGTM -- simple, clean, works.

@masatake
Copy link
Member Author

@b4n Thank you for reviewing.

@masatake masatake merged commit e0dcf65 into universal-ctags:master Nov 21, 2023
38 checks passed
@k-takata k-takata changed the title SQL: extact views in "create view if not exists VIEW ..." SQL: extract views in "create view if not exists VIEW ..." Dec 12, 2023
@k-takata
Copy link
Member

It seems that there was a typo in the title of this PR. I've updated it to "extract", but is it correct?

@masatake
Copy link
Member Author

YES!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants