xpath metaparser based on libxml2 #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masatake
force-pushed
the
xpath
branch
4 times, most recently
from
96091f7
to
2e28ff4
Compare
|
Remove unnecessary white spaces.. |
|
For extension ".xml" we need a good selector. |
| xmlNode *root; | ||
| xmlXPathContextPtr ctx; | ||
|
|
||
| findRegexTags (); |
There was a problem hiding this comment.
oh, for the doctype extraction in the example. sounds a bit hacky, couldn't this be extracted with an Xpath that could get installed at runtime?
There was a problem hiding this comment.
Drive the regex parser here.
See Units/simple-glade.d/args.ctags in these commits.
There was a problem hiding this comment.
It is just an example. What I want to say is that calling findRegexTags is meaningful; it allows a user doing something hacky.
|
Scope is added but the interface between a concrete parser and xpath meta parser becomes ugly. It seems much more work is needed... |
masatake
changed the title
masatake
force-pushed
the
xpath
branch
2 times, most recently
from
264b053
to
1663ed3
Compare
masatake
changed the title
masatake
force-pushed
the
xpath
branch
3 times, most recently
from
2ac7653
to
86e956a
Compare
|
The interface of xpath meta parser is updated as @b4n suggested. |
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…ition of input file libxml2, which will be used in xpath metaparser, can tell the line number for a xml node. However, ctags requires the file position for a tag when recording. Newly introduced a data structure and functions will fill this gap. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
TODO: qualified-tags Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Experimental. Testing for new xpath metaparser. TODO: scope field. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…le contents Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Many of XML meta parser based parsers may have the same extension: xml. New selector, selectByDTD is for selecting a proper parser for the xml file. This implementation is not efficient; it crates an dom tree for selecting. The dom tree should be reused in the selected parser. This implementation is ugly; per concrete parser rules for selecting are hard-coded in selectByDTD. These rules should be in parserDefinitions. Making a XML dom tree from input memory area should be generalized. So it can be used another areas of ctags. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
I added import(i) kind to ant parser in b1fa747. This is a wrong commit now; the imported file should be recorded as a reference tag. However, current regex meta parser cannot make a reference tag. So I remove it. Fortunately exuberant-ctags doesn't have import kind. Therefore this removal doesn't break compatibility. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…cified feature Units/TEST/features was introduced to specify features needed to run the TEST case. This commit introduces a marker for skipping a test case if ctags HAS a specified feature; the test is skipped if a line of the file is started with ``!`` marker, and a target ctags have the feature specified with ``!``. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
scope field is implemented in this xpath based parser. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
added a commit
that referenced
this pull request
Jan 21, 2016
xpath metaparser based on libxml2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant.c can be rewritten with xpath metaparser.