Update engine for refinerycms 3.0.0 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bricesanchez
commented
Jun 30, 2015
bricesanchez
commented
- Add new dependencies
- Use new way to precompile assets
- Use new icons set in admin
- Use new way to permit params
* Add new dependencies * Use new way to precompile assets * Use new icons set in admin * Use new way to permit params
|
Hey Brice, thanks for your help. LGTM but we're going to have investigate the test failure. |
|
I added you to the collaborators, feel free to merge green PR that have a 👍 review |
|
Thanks @unixcharles :) |
| page_params_without_copywriting_phrases_params.merge(phrases_params) | ||
| module RefineryCopywritingControllerDecorator | ||
| def permitted_page_params | ||
| params[:page][:copywriting_phrases_attributes]={} if params[:page][:copywriting_phrases_attributes].nil? |
There was a problem hiding this comment.
Instead you can do
params[:page][:copywriting_phrases_attributes] ||= {}it has the same effect (except that it would override false too)
added 2 commits
July 6, 2015 10:16
It can now override false too. Thanks @unixcharles Remove useless nil? check in permitted_page_params
|
Is it ok for you @unixcharles ? :) |
|
👍 |
unixcharles
added a commit
that referenced
this pull request
Jul 8, 2015
Update engine for refinerycms 3.0.0
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.