Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silent log level does not work #97

Closed
regevbr opened this issue May 7, 2020 · 0 comments · Fixed by #98
Closed

silent log level does not work #97

regevbr opened this issue May 7, 2020 · 0 comments · Fixed by #98

Comments

@regevbr
Copy link
Contributor

regevbr commented May 7, 2020 •
edited
Loading

The current logic of deciding if log level is enabled is by checking that the desired log level is lower than the set log level.
https://github.com/nuxt-contrib/consola/blob/28a61980aecbb41837b1dc81f87d6f6e76f7dcde/src/consola.js#L224
If we use infinity as the silent value, that will effectively cause all log levels to log.
We need to set silent log level to be -infinity
regevbr added a commit to regevbr/consola that referenced this issue May 7, 2020
@regevbr
fix: silent log level does not work unjs#97
5fbd732
@regevbr regevbr mentioned this issue May 7, 2020
Merged
regevbr added a commit to regevbr/consola that referenced this issue May 9, 2020
@regevbr
fix: silent log level does not work unjs#97
4d09675
regevbr added a commit to regevbr/consola that referenced this issue May 9, 2020
@regevbr
fix: silent log level does not work unjs#97
327523a
regevbr added a commit to regevbr/consola that referenced this issue May 9, 2020
@regevbr
fix: silent log level does not work unjs#97
59cf6a1
regevbr added a commit to regevbr/consola that referenced this issue May 9, 2020
@regevbr
fix: silent log level does not work unjs#97
28c13e9
@pi0 pi0 closed this as completed in #98 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: silent log level does not work #97 regevbr/consola
1 participant
@regevbr