feat!: support generic type with unknown default
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
unkown defaultunknown default
pi0
added a commit
that referenced
this pull request
Jun 12, 2023
|
beautiful 👌 |
| @@ -27,37 +27,40 @@ export type Options = { | |||
| strict?: boolean; | |||
| }; | |||
|
|
|||
| export default function destr(value: any, options: Options = {}): any { | |||
| export default function destr<T = unknown>( | |||
| value: any, | |||
There was a problem hiding this comment.
Not to be extra difficult, but should this be an unknown as well to improve destr's own type safety? By treating the parameter as any, the type checking within this function block is effectively disabled 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.parsereturns any type. This makesdestrtype safe by default and allow specify types using generics.This feature will be available for
destr>=2.0.0Credits to @rijkvanzanten (unjs/h3#387) <3