-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(readBody): set default return type to unknown
#387
Conversation
readBody
to unknown
readBody
to unknown
readBody
to unknown
unknown
The return type of This change is also breaking for types in existing projects. I would be happy to discuss about possible breaking change in next major versions of h3/nitro or alternatively have a more specific util like |
I don't believe replacing with Users who do not care about type safety in this kind of way can always set |
I'm pretty sure JSON.parse is any because it was typed before
Which is your design decision! 😄 IMO that should be unknown as well
I fully agree, which is why I proposed this change. Right now, by default, |
destr v2 is out with default |
@pi0 Is there any public issue tracker or milestone to keep up with the development of the next major version? 🙂 |
We have added todos in the code to change from #459 adds safe and validated (type + runtime) alternative utils and #417 a much better way to type events input via the Event handler itself. Let's keep tracking it by #386 (closing this PR to clear up open PRs) and thanks again for pushing forward this important change in typings. |
Fixes #386