Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add usage example for handleCors #747

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

jolo-dev
Copy link
Contributor

@jolo-dev jolo-dev commented May 7, 2024

πŸ”— Linked issue

#744

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added an example to the CORS Documentation

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@manniL manniL changed the title docs(Documentation updates): Add example to the CORS documentation docs: Add example to the CORS documentation May 8, 2024
@pi0 pi0 changed the base branch from main to chore/playground June 17, 2024 11:35
@pi0 pi0 changed the base branch from chore/playground to main June 17, 2024 11:35
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 79.80%. Comparing base (a58d7c9) to head (560ca32).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
+ Coverage   77.83%   79.80%   +1.97%     
==========================================
  Files          47       53       +6     
  Lines        4286     5314    +1028     
  Branches      611      674      +63     
==========================================
+ Hits         3336     4241     +905     
- Misses        933     1055     +122     
- Partials       17       18       +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title docs: Add example to the CORS documentation docs: add usage example for handleCors Jun 17, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 1a1d320 into unjs:main Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants