-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: print qr code for public address #89
Conversation
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 49.75% 51.69% +1.94%
==========================================
Files 10 10
Lines 1415 1472 +57
Branches 101 110 +9
==========================================
+ Hits 704 761 +57
Misses 711 711
|
const firstPublicIPv4 = urls.find( | ||
(url) => url.public && url.type === "ipv4", | ||
); | ||
if (firstPublicIPv4 && options?.qrcode !== false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might adjust this change this behavior for be for non test/ci and also when public IP is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π₯
π Linked issue
close #87
β Type of change
π Description
This PR also expose new utils
getURLs
for structure data of the URLs, so the user could render URLs in their own format if needed.π Checklist