fix(helpers): improve deepMergeObject handling case #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tahul
changed the title
antfu
reviewed
May 23, 2023
| }; | ||
|
|
||
| // Recursively merge existing object with `obj` | ||
| deepMergeObject(mod.exports.default, obj); |
There was a problem hiding this comment.
The test you provided was deepMergeObject(mod, obj) - which isn't the right target to merge. Does the same bug happen to your codebase?
Meanwhile it does help to identify a bug in the deep merge function tho. Thanks!
There was a problem hiding this comment.
I wasn't sure it was the way to use it, I landed on the same Cannot set property 'value' on type undefined error, so I thought this was an equivalent.
By using your modified version of deepMergeObject in my codebase, I get the expected result!
Thank you so much for digging in! 🙏
antfu
changed the title
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 92.05% 92.13% +0.07%
==========================================
Files 24 24
Lines 1612 1615 +3
Branches 293 296 +3
==========================================
+ Hits 1484 1488 +4
+ Misses 128 127 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello;
Following https://github.com/nuxtlabs/studio-api/issues/708
This adds two tests:
recursively create objectsrecursively merge objectsrecursively create objectsusingdeepMergeObjectThank you for helping!