Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark renderer as optional #1069

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix: mark renderer as optional #1069

merged 2 commits into from
Mar 22, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We test if renderer exists, so I think we can safely mark this as an optional type:

if (nitro.options.renderer) {
handlers.push({
route: "/**",
lazy: true,
handler: nitro.options.renderer,
});
}

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@2dcd2c7). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head f03127e differs from pull request most recent head 37dc54b. Consider uploading reports for the commit 37dc54b to get more accurate results

@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage        ?   67.32%           
=======================================
  Files           ?       62           
  Lines           ?     6292           
  Branches        ?      707           
=======================================
  Hits            ?     4236           
  Misses          ?     2042           
  Partials        ?       14           
Impacted Files Coverage Ξ”
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0
Copy link
Member

pi0 commented Mar 22, 2023

What issue does this fix?

Copy link
Member Author

removing renderer from nitro options when using nitro programmatically: https://github.com/nuxt/nuxt/pull/19825/files#diff-85b4fe47ac4284e88552626029d5147793563b4dcdab205cd8dc6afb190222aaR239-R240

@pi0 pi0 merged commit 300df93 into main Mar 22, 2023
@pi0 pi0 deleted the fix/optional-renderer branch March 22, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants