Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel, netlify): keep default behavior for static and swr to isr mapping #1155

Merged
merged 7 commits into from
Apr 21, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #1145

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a compatibility layer to keep user config working if using swr or static on Vercel + Netlify, with a deprecation warning.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 17, 2023
@danielroe danielroe self-assigned this Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1155 (ba1a692) into main (b320208) will increase coverage by 0.15%.
The diff coverage is 92.98%.

@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   76.81%   76.96%   +0.15%     
==========================================
  Files          67       67              
  Lines        6556     6613      +57     
  Branches      694      720      +26     
==========================================
+ Hits         5036     5090      +54     
- Misses       1519     1522       +3     
  Partials        1        1              
Impacted Files Coverage Ξ”
src/presets/vercel.ts 93.81% <92.59%> (+0.26%) ⬆️
src/presets/netlify.ts 78.24% <93.33%> (+2.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix: add backwards-compatible support for swr and static on verce… fix(vercel, netlify): backward compatiblity for static and swr Apr 17, 2023
src/presets/netlify.ts Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Apr 18, 2023

Shall we handle static rule flag too?

@pi0 pi0 changed the title fix(vercel, netlify): backward compatiblity for static and swr fix(vercel, netlify): keep default behavior for static and swr to isr mapping Apr 21, 2023
@pi0 pi0 merged commit e87ccff into main Apr 21, 2023
@pi0 pi0 deleted the fix/legacy-swr branch April 21, 2023 08:49
@pi0 pi0 mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add backwards-compatible layer for old static route rules
2 participants