Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade unimport to support autoImport: false #1297

Closed
wants to merge 1 commit into from

Conversation

antfu
Copy link
Member

@antfu antfu commented Jun 9, 2023

πŸ”— Linked issue

close #1288

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I implemented it in the unplugin of unimport. So there is nothing need to do on nitro side other than upgrade.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸΌ

(for the context, previously, we had #imports alias to the nitro core imports when plugin was being disabled. this seems better as also brings user/h3 imports)

@pi0
Copy link
Member

pi0 commented Jun 20, 2023

Upgrade to 3.0.8 is done in main branch (Thanks for PR BTW!)

@pi0 pi0 closed this Jun 20, 2023
@pi0 pi0 deleted the feat/unimport-disable-auto-import branch June 20, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#imports does not works with imports: false option
3 participants